Skip to content

[Refactor] base url 변경 및 targetSDK 변경 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tristanjung1006 wants to merge 2 commits into from
Closed

[Refactor] base url 변경 및 targetSDK 변경 #114

tristanjung1006 wants to merge 2 commits into from

Conversation

@tristanjung1006
Copy link
Contributor

@tristanjung1006 tristanjung1006 commented Aug 1, 2025 •
edited by coderabbitai bot
Loading

#️⃣연관된 이슈

#113

📝작업 내용

image

Summary by CodeRabbit

  • 새로운 기능

    • 앱 버전이 2.1.0으로 업데이트되었습니다.

  • 버그 수정

    • 네트워크 요청에 사용되는 기본 URL이 "to-you.store"에서 "to-you.shop"으로 변경되었습니다.

  • 기타

    • 앱의 타겟 및 컴파일 SDK 버전이 35로 상향 조정되었습니다.
    • 마이페이지에서 표시되는 버전 정보가 최신 버전으로 반영되었습니다.

@tristanjung1006 tristanjung1006 self-assigned this Aug 1, 2025
@tristanjung1006 tristanjung1006 added the ♻️ refactor 코드 개선 label Aug 1, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 1, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

앱의 빌드 설정에서 compileSdk 및 targetSdk 버전이 35로 상향 조정되었고, 앱 버전 코드와 버전명이 업데이트되었습니다. 네트워크 관련 모듈에서 API의 기본 URL이 "to-you.store"에서 "to-you.shop"으로 변경되었습니다. 서비스 버전 문자열도 "2.1.0"으로 수정되었습니다.

Changes

Cohort / File(s) Change Summary
빌드 및 버전 관리
app/build.gradle.kts, app/src/main/res/values/strings.xml		 compileSdk/targetSdk를 35로, versionCode를 12로, versionName을 "2.1.0"으로 업데이트. 서비스 버전 문자열도 "2.1.0"으로 변경.
네트워크 모듈 - 기본 URL 변경
app/src/main/java/com/toyou/toyouandroid/network/AuthNetworkModule.kt, app/src/main/java/com/toyou/toyouandroid/network/NetworkModule.kt, app/src/main/java/com/toyou/toyouandroid/network/RetrofitInstance.kt		 네트워크 요청의 기본 URL을 "https://to-you.store"에서 "https://to-you.shop"으로 변경. RetrofitInstance에서 interceptor 캐스팅 코드 간소화.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant NetworkModule
    participant API (to-you.shop)

    App->>NetworkModule: API 요청 생성
    NetworkModule->>API (to-you.shop): https://to-you.shop로 요청 전송
    API (to-you.shop)-->>NetworkModule: 응답 반환
    NetworkModule-->>App: 응답 전달
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3분

Possibly related issues

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48ac9a3 and 1fb7842.

📒 Files selected for processing (5)
  • app/build.gradle.kts (1 hunks)
  • app/src/main/java/com/toyou/toyouandroid/network/AuthNetworkModule.kt (1 hunks)
  • app/src/main/java/com/toyou/toyouandroid/network/NetworkModule.kt (1 hunks)
  • app/src/main/java/com/toyou/toyouandroid/network/RetrofitInstance.kt (1 hunks)
  • app/src/main/res/values/strings.xml (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tristanjung1006 tristanjung1006 deleted the refactor branch August 1, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeong724 jeong724 Awaiting requested review from jeong724

Assignees

@tristanjung1006 tristanjung1006

Labels

♻️ refactor 코드 개선

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tristanjung1006